Skip to content

fix: restore audio for suspended and late-joining clients - #38

Merged
LukeGus merged 1 commit into
Termix-SSH:dev-1.4.0from
ZacharyZcR:fix/builtin-rdp-audio-19
Nov 7, 2026
Merged

LukeGus merged 1 commit into
Termix-SSH:dev-1.4.0from
ZacharyZcR:fix/builtin-rdp-audio-19

Conversation

@ZacharyZcR

Copy link
Copy Markdown
Member

Two client-side paths could leave an otherwise active audio stream silent: browsers may suspend Guacamole's AudioContext until user activation, and viewers joining after the first PCM packet never received the existing stream declaration.

Resume suspended audio on remote-desktop pointer/keyboard interaction and remove the listeners on disconnect. Send the current audio declaration only to newly joined viewers and recording snapshots, without reopening existing viewers' players. Add troubleshooting guidance for the effective application log level and PCM transport diagnostics.

Validation:

  • 446 tests passed, 1 skipped; typecheck, build, validate and formatting passed.
  • Real EngineCore/EngineSession regression covers joins, reconnects, format changes and recording snapshots; the new regressions fail against the old core.
  • Local Chromium with enforced autoplay policy remained suspended with the original code and resumed after a trusted session click with the fix.
  • Actual Guacamole Client/RawAudioPlayer rendered synthetic stereo PCM through WebAudio with zero sample error over the checked frames.

Related to #19. The affected Windows target was not available: these verified fixes do not establish or resolve the reported initial missing PCM or approximately 40-second Windows 11 LTSC stall. No native engine/WASM changes are included.

@termix-triage-bot

Copy link
Copy Markdown

AI review | Looks safe to merge

This PR resumes suspended browser audio contexts on user interaction and sends audio stream declarations to late-joining clients and recordings. The changes are safe, well-tested, and follow repository standards.

Reviewed c8962a9. AI can be wrong, a maintainer still decides. Comment /termix review to run it again.

@LukeGus
LukeGus merged commit 16a3a95 into Termix-SSH:dev-1.4.0 Nov 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants