Repository navigation
fix: restore audio for suspended and late-joining clients - #38
Merged
Merged
Conversation
|
AI review | Looks safe to merge This PR resumes suspended browser audio contexts on user interaction and sends audio stream declarations to late-joining clients and recordings. The changes are safe, well-tested, and follow repository standards. Reviewed c8962a9. AI can be wrong, a maintainer still decides. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two client-side paths could leave an otherwise active audio stream silent: browsers may suspend Guacamole's AudioContext until user activation, and viewers joining after the first PCM packet never received the existing stream declaration.
Resume suspended audio on remote-desktop pointer/keyboard interaction and remove the listeners on disconnect. Send the current audio declaration only to newly joined viewers and recording snapshots, without reopening existing viewers' players. Add troubleshooting guidance for the effective application log level and PCM transport diagnostics.
Validation:
Related to #19. The affected Windows target was not available: these verified fixes do not establish or resolve the reported initial missing PCM or approximately 40-second Windows 11 LTSC stall. No native engine/WASM changes are included.