Repository navigation
fix: enable non-AVC RDP graphics pipeline - #37
Merged
Merged
Conversation
|
AI review | Looks safe to merge Enables the RDP Graphics Pipeline client independently of display control, updates the bundled WASM engine hash, and adds regression tests for capability negotiation and frame processing. No security risks or bugs found. Partial review: 1 file(s) could not be read, a maintainer should look at them. Reviewed 709e8ad. AI can be wrong, a maintainer still decides. Comment |
# Conflicts: # src/backend/engine/wasm/engine_bg.wasm # src/backend/engine/wasm/source-hash.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built-in engine disabled Graphics Pipeline negotiation and only registered dynamic channels when display resizing was enabled. Servers requiring MS-RDPEGFX could therefore fail before displaying a desktop.
Register IronRDP's Graphics Pipeline client independently of display control and advertise its supported non-AVC capabilities. Forward ResetGraphics size changes before dirty-frame events, and rebuild the bundled WASM engine.
Validation:
Related to #28. This does not add H.264/AVC420/AVC444 decoding or establish live GNOME/KDE compatibility. AVC-only servers still require a compatible external backend; the README documents the manual per-host option. No live TLS/NLA desktop acceptance has been performed.