Repository navigation
feat: allow disabling automatic RDP resizing - #36
Merged
LukeGus merged 2 commits intoNov 7, 2026
Merged
Conversation
|
AI review | Looks safe to merge Adds a host setting to disable automatic RDP resolution resizing, passing the flag through the frontend components and updating resize logic to respect it. The implementation is clean, well-tested, and follows plugin conventions with no security or stability risks. Reviewed c6c8fdc. AI can be wrong, a maintainer still decides. Comment |
# Conflicts: # locales/en.json # locales/translated/zh_CN.json # locales/translated/zh_TW.json # manifest.json # src/backend/host-settings.ts # src/frontend/GuacamoleApp.tsx # src/frontend/host-remote.ts # src/frontend/remote-form.ts # tests/frontend/GuacamoleDisplay-resize.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resizing a Termix window currently changes the remote RDP desktop resolution, moving windows and icons even when the user only wants to resize the local view. Add an "Automatically resize RDP" switch under the host's Display settings, enabled by default.
With the switch off, Auto measures the viewport when connecting and keeps that remote resolution for the session. Reconnecting measures the current viewport again. Explicit resolutions, other protocols, and existing local fit/zoom behavior remain unchanged. The per-host setting persists and preserves false on import.
Closes #31.
Validation: 451 tests passed, 1 skipped. Actual display-component regressions inspect initial connection dimensions and sendSize calls, covering the opt-out, resize, reconnect, defaults, fixed dimensions and VNC. The opt-out regression fails against the original component. Host editor integration tests verify the real switch and persistence. Clean npm ci, typecheck, build, manifest validation, pack and formatting passed. Real Windows RDP server acceptance remains unverified.