Repository navigation
feat: allow disabling automatic RDP reconnection - #35
Merged
LukeGus merged 2 commits intoNov 7, 2026
Merged
Conversation
|
AI review | Looks safe to merge Adds a per-host toggle to disable automatic RDP reconnection, preserving existing behavior by default. The implementation correctly scopes the setting to RDP, handles form state and imports safely, and includes comprehensive tests. Reviewed dfc73a8. AI can be wrong, a maintainer still decides. Comment |
# Conflicts: # locales/en.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unattended Termix tab can reconnect after its RDP session is lost and interrupt a session opened from another client. Add an "Automatically reconnect RDP" switch in the host editor's Connection section, enabled by default to preserve existing behavior.
When disabled, session loss stays on the disconnected screen until the user reconnects manually. Persist the per-host setting, retain explicit false on import, and leave other protocols unchanged. The setting controls reconnection after session loss; it does not infer server disconnect reasons.
Closes #30.
Validation: 450 tests passed, 1 skipped; clean npm ci, typecheck, build, manifest validation, pack and formatting passed. Component regressions verify no new token after session loss when disabled, manual retry, default-enabled behavior and VNC isolation. Host editor/form tests cover the actual toggle, saved settings and import. The opt-out regression fails against the original component. Real Windows RDP server acceptance remains unverified.