Repository navigation
fix: send Korean IME toggle keys as stateless pulses - #34
Merged
Merged
Conversation
|
AI review | Looks safe to merge Intercepts Korean IME toggle keys to send immediate down/up pulses, bypassing Guacamole's internal state tracking to prevent latching on drivers that omit keyup events. The change removes complex repeat-filtering logic and replaces it with direct event interception, with updated tests covering the new behavior. No security, stability, or rule violations found. Ready to merge. Reviewed 0eff5f4. AI can be wrong, a maintainer still decides. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Korean keyboard drivers that omit Hangul/Hanja keyup events leave Guacamole's pressed-key table latched after the first tap. Later taps never reach the remote session.
Handle these toggle keys in DOM capture as one down/up pulse per non-repeated keydown, through the existing focus guard. Keep them out of Guacamole's held-key and software-repeat state; suppress repeated and delayed release events without changing ordinary key handling.
Related to #22.
Validation: real Guacamole.Keyboard and production focus-handler regressions fail before the fix and pass afterward, covering repeated physical taps without keyup, held keys, DOM repeats, delayed keyup/keypress, and hidden displays. Full suite: 442 passed, 1 skipped. Clean npm ci, typecheck, build, manifest validation, formatting and pack passed. Physical Korean keyboard and remote Windows VM acceptance remain unverified.