Repository navigation
Conversation
tlysanhuo
marked this pull request as ready for review
November 5, 2026 09:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording a form submission or reset could omit the click entirely: input submit/reset/image controls entered the text-fill path, and buttons beside search fields could be swallowed by the search-decoration heuristic. Keep those controls on the click path and use reset inputs’ visible values as their recorded names.
Fixes #593.
The regression cases cover filling then clicking submit/reset/image buttons, ordinary input buttons and nested button content, with and without a search field. They assert trusted browser clicks, actual submit/reset events, the fill-before-click order and the reset field value. Search decoration still produces no extra click. Includes opt-in browser regressions and paired English/Chinese changelog entries.
Validation on Node.js 22.23.4 / Chrome for Testing 157.0.8103.38 (Linux):
pnpm lintpassed. The lint command includes DSH checks: 713 tests passed, 10 skipped; upstream dependency source-map warnings were non-fatal.git diff --checkpassed.Browser tests bundle and run the production capture module using native CDP input in an isolated browser/profile. This is not a full installed-extension/daemon/CLI end-to-end run. Rust tests were not run because no Rust code changed.
Implemented and tested with Codex assistance; no independent human review is claimed.
Run the browser regressions with:
BSK_CLICK_CHROME=/path/to/chrome pnpm --filter @browser-skill/extension exec vitest run src/content/__tests__/record-input-buttons.browser.test.tsThe browser regressions are opt-in and were run locally; this PR does not change CI workflows.