Repository navigation
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
/jira ARCH |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
WalkthroughThis pull request removes client and server helpers and exports. It updates the engagement dashboard story to import Fuselage color tokens and changes outbound-message type imports to target the ChangesUtility and export cleanup
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: deleting unused or orphaned modules as a refactor. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Errors were encountered while retrieving linked issues.
Errors: 1
-
- JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #43046 +/- ##
===========================================
+ Coverage 71.45% 71.49% +0.04%
===========================================
Files 5295 5295
Lines 228091 228091
Branches 42229 42334 +105
===========================================
+ Hits 162981 163084 +103
+ Misses 59884 59784 -100
+ Partials 5226 5223 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
1 participant
Proposed changes (including videos or screenshots)
Deletes modules in
apps/meteorthat nothing imports. Each was found with an esbuild reachability graph from the client and server entry points (plus every spec, story and test file as an extra entry), then confirmed by grepping the repo for the exported symbol.Deleted, unreachable from any entry point:
client/lib/utils/callWithErrorHandling.ts,client/lib/utils/timeAgo.tsserver/lib/cloud/{checkUserHasCloudLogin,finishOAuthAuthorization,getOAuthAuthorizationUrl,getWorkspaceKey,startRegisterWorkspace}.tsserver/lib/http/call.ts,server/lib/integrations/lib/compileIntegrationScript.tsserver/lib/users/{getStatusText,gravatarDeprecation}.ts,server/lib/utils/functions/isDocker.tsee/server/sdk/types/index.ts(type barrel; callers import from the source files)Narrowed:
engagementDashboard/dataView/colors.tswas only used byLegendSymbol.stories.tsx; inlined into the story.OutboundMessageWizard/forms/index.tsre-exported runtime modules but its two importers only neededSubmitPayload; replaced byforms/SubmitPayload.ts.Issue(s)
Steps to test or reproduce
No behavior change. Typecheck and unit tests cover it.
Further comments
Left out on purpose:
ee/server/patches/fetchContactHistory.tsis also never imported, but it is a missing wire-up rather than dead code; it is fixed infix/contact-history-source-filter.server/lib/cloud/userLogout.tsis only reached from its own test; removing it with its test is a separate change.🤖 Generated with Claude Code
Task: ARCH-2585
Summary by CodeRabbit