Repository navigation
fix: recover missing selected maps without caching placeholders - #995
Open
endoftheline818 wants to merge 1 commit into
Open
endoftheline818 wants to merge 1 commit into
endoftheline818 wants to merge 1 commit into
Conversation
swastiktawate
approved these changes
Oct 28, 2026
swastiktawate
left a comment
There was a problem hiding this comment.
This is a thorough fix. The recovery path is properly guarded — idle/charging states only, never while cleaning or returning — and the fallback to recover_missing=False on a busy device means a locked action degrades gracefully instead of failing the whole refresh. Filtering placeholder 'NO MAP' images out of both the in-memory and persisted cache is the right call, and the guard matrix plus the exactly-once reload assertion in the tests show the edge cases were thought through.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some vacuums show "NO MAP" even though a saved map is already selected. Selecting that same map again restores the image. This change performs that recovery automatically when the vacuum is idle or charging, without interrupting cleaning or a return to the dock.
The fix belongs in HomeTrait, as requested in home-assistant/core#186678:
Fixes #985. Related: home-assistant/core#185133 and home-assistant/core#186678.
Validation:
Tests use simulated device responses. A physical Q5 Pro has not been tested with this change.
AI assistance: OpenAI Codex helped prepare and test this change under the contributor's direction.