Repository navigation
Conversation
Contributor
📋 Check Results✨ JS SDK - Code FormattingShow format check results🔍 JS SDK - TypeScript Type CheckShow type check output🧪 JS SDK - Test ResultsShow test output📝 JS SDK - Lint CheckShow lint results🌐 JS SDK - Browser CompatibilityShow browser test results🌐 Browser Compatibility ReportBrowser compatibility tests completed across:
The SDK has been verified to work in modern browser environments. Check run: https://github.com/Phala-Network/phala-cloud/actions/runs/42590767483 |
h4x3rotab
changed the title
h4x3rotab
changed the title
Route bodyless GET/HEAD requests through the existing retry helper. Cover quota waits longer than the HTTP timeout, deadline cancellation, and unchanged POST retry behavior. Keep CI compatible with the current runner images and pinned Bun version.
h4x3rotab
force-pushed
the
fix/rate-limited-read-retries
branch
from
November 9, 2026 09:05
4990544 to
b3a1f2f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terraform environment updates could fail immediately when their
GetCVMInforead received HTTP 429, even though the Go SDK already had retry handling for writes.Route bodyless GET/HEAD requests through the existing
doWithRetryhelper. Reuse its retry budget,Retry-After, exponential backoff and context cancellation. The production fix adds 13 lines, with no new dependencies or configuration.The virtual-clock regression covers GET/HEAD recovery after a 60-second quota wait with a 30-second HTTP timeout, operation deadline cancellation, and no new automatic POST retries. Retain the upstream-sync CI fixes: Go race testing, Ubuntu 24.04 for Playwright's WebKit ABI, and the repository's pinned Bun version in CLI CI.
The entire PR is 91 added lines and 5 deleted lines across five files, including tests, changelog and CI. JavaScript and Python are unchanged.
Validation:
go test -race ./...andgo vet ./...pass.TestCVMEnvCreateSurvivesReadThrottlingpasses with race detection, including exactly one encrypted environment update.