Repository navigation
chore(deps): take affinidi-did-resolver-cache-sdk 0.8.40 — a deactivated did:webvh no longer resolves - #2
Merged
Merged
Conversation
…ted did:webvh no longer resolves Lockfile-only. affinidi-did-resolver-cache-sdk 0.8.38 -> 0.8.40 and did-scid 0.2.7 -> 0.2.8, both reached transitively through vta-sdk from demo/ (pcs-vetting-prototype). Before cache-sdk 0.8.39 (affinidi/affinidi-tdk-rs#907) a did:webvh whose log ends in a deactivation resolved Ok to its last DID document, keys included; 0.8.39 makes that resolution fail, and did-scid 0.2.8 does the same for did:scid:vh. 0.8.40 is a clippy-only follow-up with no behaviour change. Refs SEC-4045 / VGI-04. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SEC-4045 / VGI-04. Up to
affinidi-did-resolver-cache-sdk0.8.38, resolving adid:webvhwhose log ends in a deactivation entry returned the last DID document asOk, keys and all. Anything that trusts a DID through the cache SDK therefore kept accepting a deactivateddid:webvh. 0.8.39 (affinidi/affinidi-tdk-rs#907) makes that resolution fail, the same way a deactivateddid:web(a 404) already did.did-scid0.2.8 does the same fordid:scid:vh.This repo only reaches the crate transitively:
demo/(pcs-vetting-prototype) →vta-sdk→affinidi-did-resolver-cache-sdk. The library cratepredicate-credential-systemdoesn't depend on it at all.origin/mainhad the lockfile at 0.8.38. A survey found nothing here that depends on a deactivateddid:webvhresolving.What
This only changes the lockfile:
cargo update -p affinidi-did-resolver-cache-sdk -p did-scid, with no barecargo update. No manifest names a cache-sdk floor, so this fixes what this repo builds. It doesn't change what downstream consumers resolve.Lockfile changes (
git diff Cargo.lock)affinidi-did-resolver-cache-sdkdid-scidNo other packages moved. 0.8.40 is the newest release compatible with the MSRV (1.95). It is a clippy-only follow-up to 0.8.39 (a
collapsible_iflet-chain) with no behaviour change.Verification
Run locally with the same commands as
ci.yml, on stable (rustc 1.99.0) unless noted:cargo fmt --all -- --check: passescargo clippy -p predicate-credential-system --all-targets --all-features -- -D warnings: passescargo test -p predicate-credential-system --all-features --all-targets: passescargo build -p predicate-credential-system --no-default-features: passesRUSTDOCFLAGS="-D warnings" cargo doc --no-deps -p predicate-credential-system --features serde: passescargo +1.95.0 check -p predicate-credential-system --all-features(MSRV): passescargo package -p predicate-credential-system --locked: passesCI doesn't cover
demo/, which is the crate that actually uses the updated package, so I also ran:cargo test -p pcs-vetting-prototype --locked: passes (14 tests)Compatibility
There is no API change. The only behaviour change: a deactivated
did:webvh/did:scid:vhnow fails to resolve instead of returning its last document. The published library crate is unaffected because it doesn't depend on the resolver.