Skip to content

fix(linter): reject duplicate ids, missing root xmlns and css escapes (#237) - #248

Merged
BharathASL merged 2 commits into
mainfrom
fix/vector-linter-duplicate-ids-and-escapes
Oct 7, 2026
Merged

BharathASL merged 2 commits into
mainfrom
fix/vector-linter-duplicate-ids-and-escapes

Conversation

@BharathASL

Copy link
Copy Markdown
Contributor

Description

Resolves #237. Rejects duplicate element IDs, missing root SVG xmlns attributes, and CSS backslash escapes in tools/lib/vector-linter.mjs. In addition, rewords the marker shorthand prohibition in comments and CONTRIBUTING.md as a policy rule across all forms in favour of explicit longhands.

Affected Assets

  • None (tooling and test suite only)

Type of Change

  • feat: New vector texture master, blockstate, or compiler capability
  • fix: Tiling fix, palette correction, or bugfix
  • docs: Documentation improvement
  • chore / refactor: Maintenance, dependencies, or codebase cleanup

Contributor Checklist

Please check all applicable boxes before requesting review:

Vector Texture Standards (if adding/modifying SVGs)

  • Authored as a clean $512\times512$ SVG (viewBox="0 0 512 512").
  • Primary shapes are aligned to the $32\text{px}$ texel grid ($16\times16$ grid).
  • Seamless Toroidal Tiling: Checked and verified that elements wrapping across $X$ and $Y$ edges align perfectly without seams or chopped shapes.
  • Ore Consistency: If adding an ore texture, the stone background geometry and corner radius (rx) match textures/block/stone.svg exactly.
  • Free of leftover AI generation comments, unnecessary editor namespaces, or embedded raster images.

Build & Verification

  • Ran npm run build locally and verified that the pack compiles successfully.
  • Verified textures in-game or inspected the rasterized PNG outputs in dist/.

Git Hygiene & Standards

  • Commit message(s) follow Conventional Commits (e.g., feat(textures): ...).
  • Every commit is signed off with the Developer Certificate of Origin (git commit -s).
  • Branch is rebased cleanly onto latest main with no merge commits.
  • Formatting complies with .editorconfig (2-space indent, LF endings, trailing newline).

…#237)

Enforce unique element IDs, require root SVG namespace declaration,
and reject CSS backslash escapes in the vector master linter.

Signed-off-by: Bharath <bharathasl74185@gmail.com>
…capes

Enforce unprefixed <svg> root element, require exact xmlns URI match without
trimming, and reject CSS backslash escapes in style rule selectors.

Signed-off-by: Bharath <bharathasl74185@gmail.com>

@ninja6-agent ninja6-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@BharathASL
BharathASL added this pull request to the merge queue Oct 7, 2026
Merged via the queue into main with commit e30aca0 Oct 7, 2026
5 checks passed
@BharathASL
BharathASL deleted the fix/vector-linter-duplicate-ids-and-escapes branch October 7, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vector linter: reject duplicate ids, namespace-less roots and escaped url(), and fix the marker shorthand claim

1 participant