Repository navigation
fix(linter): reject duplicate ids, missing root xmlns and css escapes (#237) - #248
Merged
Merged
Conversation
…#237) Enforce unique element IDs, require root SVG namespace declaration, and reject CSS backslash escapes in the vector master linter. Signed-off-by: Bharath <bharathasl74185@gmail.com>
…capes Enforce unprefixed <svg> root element, require exact xmlns URI match without trimming, and reject CSS backslash escapes in style rule selectors. Signed-off-by: Bharath <bharathasl74185@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #237. Rejects duplicate element IDs, missing root SVG xmlns attributes, and CSS backslash escapes in
tools/lib/vector-linter.mjs. In addition, rewords the marker shorthand prohibition in comments andCONTRIBUTING.mdas a policy rule across all forms in favour of explicit longhands.Affected Assets
Type of Change
feat: New vector texture master, blockstate, or compiler capabilityfix: Tiling fix, palette correction, or bugfixdocs: Documentation improvementchore/refactor: Maintenance, dependencies, or codebase cleanupContributor Checklist
Please check all applicable boxes before requesting review:
Vector Texture Standards (if adding/modifying SVGs)
viewBox="0 0 512 512").rx) matchtextures/block/stone.svgexactly.Build & Verification
npm run buildlocally and verified that the pack compiles successfully.dist/.Git Hygiene & Standards
feat(textures): ...).git commit -s).mainwith no merge commits..editorconfig(2-space indent, LF endings, trailing newline).