Repository navigation
Add opt-in global PAP:RED expansion restrictions - #1050
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PAP:RED intelligence can currently reach expansion handlers without a central policy check. Add the global
--restrict-pap-redstartup option, disabled by default, to reject marked hover requests and external expansion before any handler executes. Default requests, handler payloads and legacy JSON bytes retain their existing behavior.When enabled:
tagsarray for simplified requests. A PAP:RED marking at any supplied level wins.hover: trueidentifies hover calls; hover-only modules are recognised automatically.data-source: internalin trusted metadata. External, missing and unrecognised declarations are blocked. Add initial declarations for the Sigma syntax validator and DNS resolver.module_errors. Request configuration cannot override the server policy or source declaration. Import, export and action modules retain their existing behavior.Document startup configuration, source declarations, request context and the integration boundary, and add the optional request fields to OpenAPI.
MISP integration
Related to #576. This supplies the misp-modules server policy, rather than claiming complete end-to-end resolution: current MISP hover paths can omit tags and a hover indicator. Callers must forward effective attribute/object/event tags and identify hover calls. Requests without supplied PAP:RED markings retain their behavior; the module service cannot infer missing parent tags from an attribute ID or value. MISP-side forwarding remains necessary for complete protection, so this PR deliberately does not close the issue.
Validation
git diff --checkverified.The HTTP tests exercise both handler styles, default compatibility, parent markings, source and hover decisions, inability to bypass the policy through request config, discovery metadata and rejected-request statistics. Tests use local servers and mocked module handlers; no external intelligence service is contacted.