feat: add Coordinate List (COO) sparse matrix with get/map/mapi/set/mxm by narysh · Pull Request #20 · Lamagraph/QTreeFSharp

narysh · 2026-06-12T19:18:42Z

Implement:

Vector.filter / Matrix.filter
Vector.exists / Vector.forall (short-circuit || / &&)
Matrix.exists / Matrix.forall (short-circuit || / &&)

Tests (64 total):

Vector.filter: 9
Vector.exists: 12
Vector.forall: 12
Matrix.filter: 9
Matrix.exists: 11
Matrix.forall: 11

Benchmarks:

Filters.fs: Vector/Matrix filter (dense + sparse), N=64,256,4096
Exists.fs: Vector/Matrix exists (dense + sparse), N=64,256,4096
Forall.fs: Vector/Matrix forall (dense + sparse), N=64,256,4096
Register in BenchmarkSwitcher and .fsproj

Implement: - Vector.filter / Matrix.filter - Vector.exists / Vector.forall (short-circuit || / &&) - Matrix.exists / Matrix.forall (short-circuit || / &&) Tests (64 total): - Vector.filter: 9 - Vector.exists: 12 - Vector.forall: 12 - Matrix.filter: 9 - Matrix.exists: 11 - Matrix.forall: 11 Benchmarks: - Filters.fs: Vector/Matrix filter (dense + sparse), N=64,256,4096 - Exists.fs: Vector/Matrix exists (dense + sparse), N=64,256,4096 - Forall.fs: Vector/Matrix forall (dense + sparse), N=64,256,4096 - Register in BenchmarkSwitcher and .fsproj

gsvgit · 2026-06-13T13:27:05Z

Правда ли, что то, что Вы сделали, не выражается через map тривиальным образом,

narysh · 2026-06-13T14:34:15Z

Правда ли, что то, что вы сделали, нельзя выразить через map тривиальным образом?

filter выразить можно, но это было одной из моих задач в проекте
forall и exists можно выразить через аналог fold, но тогда он пройдёт всё дерево, а forall и exists это оптимизируют и полный обход случится, только в худшем случае.
Я понимаю, что этого мало. Остальные задачи, которые у меня были изначально, вы уже реализовали, может вы можете тогда подсказать другие функции, которые нужно реализовать?

…exists/forall tests

… test suite (188 tests)

gsvgit · 2026-09-21T08:14:29Z

+        )
+    | Error e -> failwithf "unexpected error %A" e
+
+[<Fact>]


А чего ни одного Property-based теста?

gsvgit · 2026-09-21T08:14:55Z

+        Assert.Equal(Ok(Some 11), get result 0UL<rowindex> 0UL<colindex>)
+        Assert.Equal(Ok(Some 121), get result 1UL<rowindex> 1UL<colindex>)
+
+[<Fact>]


И тут property не проверяете.

gsvgit · 2026-09-21T08:17:25Z

-            (Leaf(UserValue(res)), nnz) |> Ok
+let get (matrix: SparseMatrix<'a>) (row: uint64<rowindex>) (col: uint64<colindex>) : Result<option<'a>, Error> =
+    if uint64 row >= uint64 matrix.nrows || uint64 col >= uint64 matrix.ncols then
+        Error Error.InvalidElementIndex


Посмотрите, как обычно называется такая ситуация в .NET

gsvgit · 2026-09-21T08:17:58Z

+    | LeftValuesOnlyIndexed of (uint64<rowindex> -> uint64<colindex> -> 'a -> Option<'b> -> Option<'c>)
+
+let private applyBinary
+    (op: BinaryOp<'a, 'b, 'c>)


А нельзя ли всё это дело как-то не копировать?

…ds access, deduplicate applyBinary

…COO to COOArray - COOArray: walk the sorted array with a cursor in full-cell cooMap/cooMapi paths and buffer results in ResizeArray instead of building a lookup Map; rewrite mergeBinary as a two-pointer merge over sorted arrays - COOArray/COOList: strengthen mxmcoo optimization detection by probing all distinct values rather than only the first entry - COOList: replace Map-based lookup in full-cell cooMap/cooMap2 with a pointer walk over the sorted list - Tests: add FsCheck property tests for mxmcoo against a naive reference and cross-checks between the array and list implementations - Benchmark: add list-backed get/set cases (COOLIST_get/set, resultListVal) to Format, DenseFormat and RealMatrix benchmarks - Rename module COO to COOArray for consistency with COOList: file rename, fsproj entries, open statements, test module, and Fantomas formatting

…COO type

gsvgit · 2026-09-30T08:19:24Z

+
+    [<Benchmark(Description = "Dense_COO_mxm")>]
+    member this.DenseCooMxm() =
+        let op_add x y =


А можно не делать миллион копий одинаковых функций? Это уже не первое дублирование кода. Проверьте весь код на аккуртаность.

gsvgit

Перечитайте ВЕСЬ код. У Вас дубликатов море. И заодно порешайте концликты и коммиты подпишите.

gsvgit

Всё ещё тонны дублирующегося кода.

…tations

…dLeaf

gsvgit · 2026-10-12T07:20:02Z

+    let nrows = uint64 coo.nrows * 1UL<rowindex>
+    let ncols = uint64 coo.ncols * 1UL<colindex>
+
+    let cooGetThrows =


I hope, there is a conventional way to check whether method throws particular exception.

gsvgit · 2026-10-12T07:20:36Z

+    let toArray<'T> isArray (m: obj) : COOEntry<'T> array =
+        let listProp = m.GetType().GetProperty("list")
+
+        if listProp <> null then


Fix compiler warnings.

gsvgit · 2026-10-12T07:21:16Z

+        else
+            Result.map box (COOList.cooMap2iValues (unbox m1) (unbox m2) f)
+
+    let cooMap2iLeftValues isArray (m1: obj) (m2: obj) f =


obj type in F#? Really?

…rt.Throws, reuse OptionMonoid - Replace untyped obj, box/unbox and runtime reflection in Formats test helper with strictly typed type COO<'T> = Array | List discriminated union. - Fix all 42 compiler warnings (FS0686, FS0064) in Tests.COOFormats.fs by adding explicit generic type parameters and equality constraints. - Replace manual try/with boilerplate in PropertyTests out-of-bounds test with idiomatic Assert.Throws<ArgumentOutOfRangeException>. - Remove duplicated local definitions of opAdd and opMul in PropertyTests.fs in favor of canonical OptionMonoid.op_add and OptionMonoid.op_mult.

narysh · 2026-10-12T09:34:40Z

поменял try ... with на идиоматичный в F# Assert.Throws
заменил obj на дженерики
пофиксил warningи

gsvgit · 2026-10-14T07:51:05Z


 type Error =
    | EdgesCalculationProblem of LinearAlgebra.Error
-    | CEdgesCalculationProblem of Vector.Error


But why? What the reason of such changes?

gsvgit · 2026-10-14T07:51:10Z


 type Error =
    | NewFrontierCalculationProblem of LinearAlgebra.Error
-    | FrontierCalculationProblem of Vector.Error


But why? What the reason of such changes?

gsvgit · 2026-10-14T07:52:33Z

+
+let cooGet (coo: ArrayCOO<'a>, rowindex: uint64<rowindex>, colindex: uint64<colindex>) : Result<option<'a>, Error> =
+    if uint64 rowindex >= uint64 coo.nrows then
+        raise (System.ArgumentOutOfRangeException("rowindex", "Row index is outside the matrix bounds."))


No. We do not use exceptions.

gsvgit · 2026-10-14T07:53:04Z

+
+        i <- i + 1UL
+
+let cooGet (coo: ArrayCOO<'a>, rowindex: uint64<rowindex>, colindex: uint64<colindex>) : Result<option<'a>, Error> =


Can you use indexed properties?

gsvgit · 2026-10-14T07:53:44Z

+let private cooMapInner (coo: ArrayCOO<'a>) (op: UnaryOp<'a, 'b>) : ArrayCOO<'b> =
+    match op with
+    | UnaryOp.ValuesOnly f ->
+        let buf = ResizeArray<COOEntry<'b>>(coo.list.Length)


No resize arrays.

gsvgit · 2026-10-14T07:53:55Z

+    | UnaryOp.ValuesOnly f ->
+        let buf = ResizeArray<COOEntry<'b>>(coo.list.Length)
+
+        for (i, j, v) in coo.list do


gsvgit · 2026-10-14T07:54:51Z

+
+let cooGet (coo: ListCOO<'a>, rowindex: uint64<rowindex>, colindex: uint64<colindex>) : Result<option<'a>, Error> =
+    if uint64 rowindex >= uint64 coo.nrows then
+        raise (System.ArgumentOutOfRangeException("rowindex", "Row index is outside the matrix bounds."))


Looks like code duplicates.

gsvgit · 2026-10-14T07:55:27Z

-    (pr + halfSize * 1UL<rowindex>, pc), // SOUTH WEST
-    (pr + halfSize * 1UL<rowindex>, pc + halfSize * 1UL<colindex>) // SOUTH EAST
+[<Struct>]
+type ArrayCOO<'value> =


Array in matrix?

…es, ResizeArray and loops

… recursion

…ay and COOList

…chmark

…ies field, and Option.isNone

…omArray/toArray

- Matrix: return Error.InconsistentSizeOfArguments in get and set instead of raising ArgumentOutOfRangeException - COOArray: use array instead of seq in constructors/SortEntries, clone before sort, check op_add None None in canOptimize - COOList: remove unused range function, check op_add None None in canOptimize - Tests: update get/set test assertions to expect Error and add mxmcoo semiring fallback test

…ralResult

…yCOO and ListCOO - In ArrayCOO: added bounds validation, stable deduplication (last occurrence wins), and TryCreate returning Result<_, Error>. - In ListCOO: added sorting, deduplication, and bounds validation on construction, preventing silent None misses in findEntry. - Internal operations now construct via CreatePresorted with DEBUG assertions. - Added comprehensive unit tests in Tests.COOFormats.fs.

…, and optimize COO formats - Normalize in-bounds Dummy leaves to UserValue None in mapInner and map2Inner - Check storage.size equality before quadtree traversal in map2Inner - Add Int32 overflow guard before dense materialization in COOArray.cooMap2 - Replace entryComparer and Unchecked.defaultof with pure tail-recursive binary search in COOArray - Deduplicate array truncation logic and remove unused m1ByRow in COOList - Restrict CreatePresorted accessibility to internal in ArrayCOO and ListCOO - Add regression tests for overflow checks, storage size mismatches, and Dummy padding

…e comparison and monoid validation - Add compareCoords, entryCoordCompare, isAddNeutral and canMergeOpAdd helpers to Common.fs - Deduplicate cooMapInner and cooMap2Inner dense traversals using advanceCursor and runDense in COOList and COOArray - Unify coordinate comparisons across all sorting and search functions - Unify leaf nnz calculation in Matrix.fs with leafNnz helper and remove unreachable pattern FS0026

…low safety, and hot-path allocations - Align map2Inner Dummy handling with mapInner: handle boundary-spanning quadrants via recursive splitting and correct leafNnz calculation - Guard against Int32 overflow in COOArray.cooMapInner and COOList.cooMap2Inner on large dense operations - Add m2.nrows overflow check to COOArray.mxmcoo canOptimize - Unbox coordinates in COOList.mxmcoo reduceAdjacent to eliminate hot-path tuple allocations - Deduplicate applyBinary emission in mergeBinary across COOList and COOArray - Simplify delta calculation in Matrix.set and remove dead code

…nchmark accumulator

narysh · 2026-10-18T20:00:52Z

У большинства операций скорость не просела, даже увеличилась прикрепляю замеры
COO_Comparison_Now_vs_Before.md

gsvgit

За счёт чего производительность улучшилась?

gsvgit · 2026-10-20T07:07:36Z


 type Error =
    | NewFrontierCalculationProblem of LinearAlgebra.Error
-    | FrontierCalculationProblem of Vector.Error


Зачем убрали специфичность ошибки? Причём везде. Тип ошибки позволяет понять, где она произошла.

пофиксю, верну как было

gsvgit · 2026-10-20T07:10:39Z

Кстати, а чего отчёт не обновили?

narysh · 2026-10-20T07:16:19Z

обновил локально, сейчас открою PR

narysh · 2026-10-20T07:53:53Z

За счёт чего производительность улучшилась?

убрал ResizeArray заменив быстрым предподсчётом и аллокацией памяти 1 раз в начале
поменял сравнение координат (i1, j1) < (i2, j2) которое делалось через обобщённый метод на простое let c = compare i1 i2; if c <> 0 then c else compare j1 j2
в set сортировку поменял на поиск места вставки бин поиском + сдвиг

- Restore domain-specific Matrix.Error, Vector.Error, and LinearAlgebra.Error - Restore diagnostic error contexts in BFS, SSSP, Boruvka, MST, and TriangleCount - Move checkBounds to Matrix.fs and remove generic Common.Error

narysh · 2026-10-20T11:55:59Z

Кстати, а чего отчёт не обновили?

gsvgit/1_year_practice_2026_reports#42
вот, актуализировал замеры, остальное не трогал там

narysh added 2 commits June 12, 2026 22:04

fix: formatting

450af94

narysh added 2 commits September 17, 2026 15:13

Fix COO map/get/mapi/map/map2 on dense data, add COO tests

1430bf3

Add public Matrix get/set/map, get/set/map tests; drop Matrix.filter/…

358b541

…exists/forall tests

narysh changed the title ~~feat(quadtree): add filter, exists, forall with tests and benchmarks~~ feat: add Coordinate List (COO) sparse matrix with get/map/mapi/set/mxm Sep 17, 2026

Implement COO operations, optimize sparse mxm path, add comprehensive…

c4c72d4

… test suite (188 tests)

gsvgit requested changes Sep 21, 2026

View reviewed changes

narysh added 9 commits September 22, 2026 13:22

Fix review feedback: throw ArgumentOutOfRangeException on out-of-boun…

9ed12fa

…ds access, deduplicate applyBinary

Add FsCheck property-based tests (6 properties, 194 tests total)

0a88adf

Use array storage with binary search in COO get/update

6345980

Format files with Fantomas 7 (fix CI format-check)

a68022d

Add list-based COO representation (COOList)

b61d877

Add missing FormatBenchmarks.fs referenced by benchmark project

5e4cfda

Revert CoordinateList to list storage; split array storage into Array…

79221ed

…COO type

Merge upstream/main into narysev-work

4631871

narysh force-pushed the narysev-work branch from 890008d to 4631871 Compare September 28, 2026 18:35

gsvgit requested changes Sep 30, 2026

View reviewed changes

narysh added 3 commits September 30, 2026 16:36

fix: restore benchmark suites compilation with ArrayCOO API

fd5dca4

refactor: deduplicate op_add/op_mult and map2 lambdas in benchmarks

af75b97

style: apply fantomas formatting to benchmark files

99675aa

gsvgit requested changes Oct 2, 2026

View reviewed changes

Merge upstream/main into narysev-work

f29633d

narysh force-pushed the narysev-work branch from 92f6f9e to f29633d Compare October 3, 2026 12:44

gsvgit requested changes Oct 3, 2026

View reviewed changes

narysh force-pushed the narysev-work branch from cb90d52 to f29633d Compare October 4, 2026 10:57

narysh added 2 commits October 4, 2026 14:08

Eliminate duplications in benchmarks and tests while keeping implemen…

fdc382a

…tations

Format code using Fantomas

f2ead81

fix(Matrix): avoid eager evaluation of indexed mapping in splitIndexe…

15bcbf1

…dLeaf

gsvgit requested changes Oct 12, 2026

View reviewed changes

gsvgit requested changes Oct 14, 2026

View reviewed changes

refactor(coo): address PR review feedback on errors, indexed properti…

996899c

…es, ResizeArray and loops

narysh force-pushed the narysev-work branch from 7c42bf3 to 996899c Compare October 16, 2026 08:55

refactor(coo): eliminate ResizeArray and loops via CSR index and tail…

eec6568

… recursion

narysh force-pushed the narysev-work branch from eec6568 to 996899c Compare October 16, 2026 10:12

narysh added 4 commits October 17, 2026 00:37

perf(coo): purely functional zero-allocation optimizations for COOArr…

e8ca3ac

…ay and COOList

fix(benchmark): restore original report parameters and DenseFormatBen…

3d3cc44

…chmark

refactor(coo): add isStrictlySorted validation, CreatePresorted, entr…

2dd4662

…ies field, and Option.isNone

refactor(COOList): use coo.entries and ArrayCOO.CreatePresorted in fr…

3836ed5

…omArray/toArray

narysh force-pushed the narysev-work branch from ba48888 to 3836ed5 Compare October 16, 2026 23:47

narysh added 9 commits October 17, 2026 04:02

style: format modified files with fantomas 7.0.5

46f4a65

refactor(coo): move op_add check to canMerge, use defaultof in cooUpdate

2d17536

refactor: eliminate failwith in Matrix.set and clean up COOArray.gene…

b37ff5c

…ralResult

fix: add deterministic get/set tests, assert map2i values, and fix be…

9603a2d

…nchmark accumulator

gsvgit requested changes Oct 20, 2026

View reviewed changes


		i <- i + 1UL

		let cooGet (coo: ArrayCOO<'a>, rowindex: uint64<rowindex>, colindex: uint64<colindex>) : Result<option<'a>, Error> =

Conversation

narysh commented Jun 12, 2026

Uh oh!

gsvgit commented Jun 13, 2026

Uh oh!

narysh commented Jun 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gsvgit left a comment

Choose a reason for hiding this comment

Uh oh!

gsvgit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

narysh commented Oct 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

narysh commented Oct 18, 2026

Uh oh!

gsvgit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gsvgit commented Oct 20, 2026

Uh oh!

narysh commented Oct 20, 2026

Uh oh!

narysh commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

narysh commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

narysh commented Oct 20, 2026 •

edited

Loading