Skip to content

[DamApplication] Simplify process implementations and reduce code duplication - #14952

Merged
joaquinirazabal merged 7 commits into
masterfrom
dam/simplify-processes
Oct 28, 2026
Merged

joaquinirazabal merged 7 commits into
masterfrom
dam/simplify-processes

Conversation

@joaquinirazabal

Copy link
Copy Markdown
Member

📝 Description

This PR simplifies several C++ processes and Python wrappers in DamApplication, reducing code duplication while preserving existing numerical behavior and backward compatibility.

Key changes

  • Introduced DamNodalFieldUtilities to share nodal assignment logic across five C++ processes.
  • Simplified three Python wrappers for vector loads and constraints.
  • Reduced duplicated code in the thermal parameters assignment process.
  • Refactored DamFixTemperatureConditionProcess to reuse common assignment logic.
  • Added C++ and Python regression tests.

Validation

  • Python: 100/100 tests passed (22 new tests).

🆕 Changelog

  • Reduced duplication in nodal-field and temperature processes.
  • Simplified vector and thermal parameter wrappers.
  • Added regression tests.

…or historical value assignments

- Introduced DamNodalFieldUtilities to centralize nodal field value assignments.
- Updated DamChemoMechanicalAgingYoungProcess to use AssignYoungModulus method.
- Refactored DamInputTableNodalYoungModulusProcess to utilize AssignYoungModulus for setting values.
- Modified DamNodalReferenceTemperatureProcess to use AssignReferenceTemperature for value assignments.
- Simplified DamNodalYoungModulusProcess by implementing AssignYoungModulus for calculating and setting Young's modulus.
- Updated DamRandomFieldsVariableProcess to use DamNodalFieldUtilities for setting historical values from a table.
- Added unit tests for new functionalities in test_dam_nodal_field_processes.py to ensure correctness of nodal field assignments.
…enhance test coverage for constraint and load processes
…meter handling and add unit tests for thermal parameter assignments
…nt and enhance readability; add comprehensive unit tests for constant and table-based temperature handling
…ps for input file names and variable names, enhancing data handling and readability.
@joaquinirazabal
joaquinirazabal merged commit 020da89 into master Oct 28, 2026
10 checks passed
@joaquinirazabal
joaquinirazabal deleted the dam/simplify-processes branch October 28, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants