Skip to content

fix: declare the real minimum Node.js version - #151

Merged
Kikobeats merged 1 commit into
masterfrom
Kikobeats/fix-engines
Oct 28, 2026
Merged

Kikobeats merged 1 commit into
masterfrom
Kikobeats/fix-engines

Conversation

@Kikobeats

@Kikobeats Kikobeats commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Users on Node versions below what this package needs can install it without a warning and then crash at runtime. This declares the real minimum in engines.node.

package old floor new floor set by
cacheable-response >= 12 >= 20 @keyvhq/memoize > null-prototype-object@1.2.7 (engines >= 20)

Proof

Each suite ran with npx -y -p node@<version> -- node <test runner bin> (tests only, no lint, no c8). Where the repo's test runner refuses the target Node, an older ava or mocha ran the same test files.

  • Suite on Node 20.0.0: 41 tests passed (ava 5.3.1, since the repo's ava 7 needs ^20.19).

The floor and the dependency that sets it come from walking the installed production dependency tree and taking the highest semver.minVersion(engines.node).

🤖 Generated with Claude Code


Note

Low Risk
Metadata-only change to declared Node support; no runtime or application logic is modified.

Overview
Updates engines.node from >= 12 to >= 20 so npm can warn on install when the runtime is too old. The previous floor was lower than what the dependency tree actually requires (driven by transitive packages such as null-prototype-object under @keyvhq/memoize), which could let users install the package and fail at runtime instead of at install time.

Reviewed by Cursor Bugbot for commit 4437108. Bugbot is set up for automated code reviews on this repo. Configure here.

cacheable-response: >= 12 -> >= 20, set by @keyvhq/memoize > null-prototype-object@1.2.7
(engines >= 20)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 62110f0b-1e28-4999-a175-95ff42fbf9be
Commits

Reviewing files that changed from the base of the PR and between 9d94345 and 4437108.

Files selected for processing: 1
  • package.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kikobeats
Kikobeats merged commit 9e44192 into master Oct 28, 2026
4 checks passed
@Kikobeats
Kikobeats deleted the Kikobeats/fix-engines branch October 28, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant