Repository navigation
fix: declare the real minimum Node.js version - #151
Merged
Merged
Conversation
cacheable-response: >= 12 -> >= 20, set by @keyvhq/memoize > null-prototype-object@1.2.7 (engines >= 20) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 14 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users on Node versions below what this package needs can install it without a warning and then crash at runtime. This declares the real minimum in
engines.node.@keyvhq/memoize>null-prototype-object@1.2.7(engines>= 20)Proof
Each suite ran with
npx -y -p node@<version> -- node <test runner bin>(tests only, no lint, no c8). Where the repo's test runner refuses the target Node, an older ava or mocha ran the same test files.The floor and the dependency that sets it come from walking the installed production dependency tree and taking the highest
semver.minVersion(engines.node).🤖 Generated with Claude Code
Note
Low Risk
Metadata-only change to declared Node support; no runtime or application logic is modified.
Overview
Updates
engines.nodefrom>= 12to>= 20so npm can warn on install when the runtime is too old. The previous floor was lower than what the dependency tree actually requires (driven by transitive packages such asnull-prototype-objectunder@keyvhq/memoize), which could let users install the package and fail at runtime instead of at install time.Reviewed by Cursor Bugbot for commit 4437108. Bugbot is set up for automated code reviews on this repo. Configure here.