Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,14 @@ the release notes unless you prefer otherwise.
In scope:

- `bullet.exe`, the installer and the uninstaller,
- the native engine (`bullet-br.exe`, `bullet-br.dll`), whose source is private but whose behavior can be reported,
- the GitHub sign-in that checks the repository star,
- the party mode protocol, its encryption and the relay (`relay-worker/`, `crates/bullet-relay`),
- the terminal install script (`install.ps1`) and the in-app update, which verify the installer before running it,
- the build and release pipeline in `.github/`.

Out of scope:

- the LTK patcher binaries (report those to [League Toolkit](https://github.com/LeagueToolkit/ltk-manager)),
- the League of Legends client or game,
- detection or penalties by Riot's anti-cheat. Using Bullet is at your own risk, as the README's disclaimer
explains.
Expand Down
110 changes: 86 additions & 24 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
paths-ignore:
- "**/*.md"
- "docs/**"
- "**"
- "LICENSE"
workflow_dispatch:

Expand Down Expand Up @@ -90,11 +89,25 @@ jobs:
VERSION: ${{ needs.plan.outputs.version }}
SIGNING: ${{ secrets.SIGNPATH_API_TOKEN != '' }}
HAS_ENGINE_TOKEN: ${{ secrets.BULLET_ENGINE_PAT != '' }}
BULLET_GITHUB_CLIENT_ID: ${{ vars.BULLET_GITHUB_CLIENT_ID }}
BULLET_NATIVE_PUBLISHER: ${{ vars.BULLET_NATIVE_PUBLISHER }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Require the GitHub OAuth client ID used by StarGate
shell: pwsh
run: |
if (-not $env:BULLET_GITHUB_CLIENT_ID) {
Write-Host "::error::Set the BULLET_GITHUB_CLIENT_ID repository variable to the Client ID of the GitHub OAuth App with Device Flow enabled"
exit 1
}
if ($env:SIGNING -eq 'true' -and -not $env:BULLET_NATIVE_PUBLISHER) {
Write-Host "::error::Set the BULLET_NATIVE_PUBLISHER repository variable to the certificate subject name so Bullet refuses an engine signed by anyone else"
exit 1
}

- name: Install the pinned toolchain
run: rustup toolchain install

Expand All @@ -113,37 +126,79 @@ jobs:
- name: Build the release binary (cargo xtask package)
run: cargo xtask package

- name: Fetch proprietary native engine binaries from private repository
- name: Require access to the native engine
if: env.HAS_ENGINE_TOKEN != 'true'
shell: pwsh
run: |
Write-Host "::error::Set the BULLET_ENGINE_PAT secret; Bullet cannot ship without bullet-br.exe and bullet-br.dll"
exit 1

- name: Fetch the native engine from the private repository
if: env.HAS_ENGINE_TOKEN == 'true'
shell: pwsh
env:
GH_TOKEN: ${{ secrets.BULLET_ENGINE_PAT }}
run: |
New-Item -ItemType Directory -Force -Path "dist/tools" | Out-Null
try {
$headers = @{
Authorization = "Bearer $env:GH_TOKEN"
Accept = "application/vnd.github+json"
"X-GitHub-Api-Version" = "2022-11-28"
}
$release = Invoke-RestMethod -Uri "https://api.github.com/repos/Isllanrx/bullet_dll/releases/latest" -Headers $headers
Write-Host "Found private release: $($release.tag_name)"
foreach ($asset in $release.assets) {
if ($asset.name -match '\.(exe|dll)$') {
$targetFile = Join-Path "dist/tools" $asset.name
Write-Host "Downloading $($asset.name)..."
Invoke-WebRequest -Uri $asset.url -Headers @{
Authorization = "Bearer $env:GH_TOKEN"
Accept = "application/octet-stream"
"X-GitHub-Api-Version" = "2022-11-28"
} -OutFile $targetFile
Write-Host "Downloaded $($asset.name) to $targetFile"
}
$headers = @{
Authorization = "Bearer $env:GH_TOKEN"
Accept = "application/vnd.github+json"
"X-GitHub-Api-Version" = "2022-11-28"
}
$download = @{
Authorization = "Bearer $env:GH_TOKEN"
Accept = "application/octet-stream"
"X-GitHub-Api-Version" = "2022-11-28"
}
$release = Invoke-RestMethod -Uri "https://api.github.com/repos/Isllanrx/bullet_dll/releases/tags/engine-latest" -Headers $headers
$sumsAsset = $release.assets | Where-Object { $_.name -eq 'SHA256SUMS' }
if (-not $sumsAsset) { throw "The engine-latest release has no SHA256SUMS; rerun build-engine.yml in bullet_dll" }
$sumsFile = Join-Path $env:RUNNER_TEMP "engine-SHA256SUMS"
Invoke-WebRequest -Uri $sumsAsset.url -OutFile $sumsFile -Headers $download
$expected = @{}
foreach ($line in Get-Content $sumsFile) {
$parts = $line.Trim() -split '\s+\*?'
if ($parts.Count -eq 2) { $expected[$parts[1]] = $parts[0].ToLowerInvariant() }
}
foreach ($name in @('bullet-br.exe', 'bullet-br.dll')) {
if (-not $expected.ContainsKey($name)) { throw "SHA256SUMS of engine-latest does not list $name" }
$asset = $release.assets | Where-Object { $_.name -eq $name }
if (-not $asset) { throw "The engine-latest release has no asset named $name" }
$target = Join-Path "dist/tools" $name
Invoke-WebRequest -Uri $asset.url -OutFile $target -Headers $download
$hash = (Get-FileHash $target -Algorithm SHA256).Hash.ToLowerInvariant()
if ($hash -ne $expected[$name]) {
Remove-Item $target -Force
throw "$name has SHA-256 $hash, but engine-latest SHA256SUMS lists $($expected[$name])"
}
} catch {
Write-Warning "Could not fetch native engine assets from private repository: $_"
Write-Host "$name matches SHA256SUMS ($hash)"
}

- id: unsigned-engine
if: env.SIGNING == 'true' && env.HAS_ENGINE_TOKEN == 'true'
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: unsigned-native-engine-${{ env.VERSION }}
if-no-files-found: error
path: |
dist/tools/bullet-br.exe
dist/tools/bullet-br.dll

- name: Sign the native engine (SignPath)
if: env.SIGNING == 'true' && env.HAS_ENGINE_TOKEN == 'true'
uses: signpath/github-action-submit-signing-request@f6d04783b4569d051e0c80105fe66e82819d0092 # v3.0
with:
connector-url: https://githubactions.connectors.signpath.io
api-token: ${{ secrets.SIGNPATH_API_TOKEN }}
organization-id: ${{ vars.SIGNPATH_ORGANIZATION_ID }}
project-slug: ${{ vars.SIGNPATH_PROJECT_SLUG }}
signing-policy-slug: ${{ vars.SIGNPATH_SIGNING_POLICY_SLUG }}
artifact-configuration-slug: ${{ vars.SIGNPATH_ENGINE_CONFIGURATION_SLUG }}
github-artifact-id: ${{ steps.unsigned-engine.outputs.artifact-id }}
wait-for-completion: true
wait-for-completion-timeout-in-seconds: 3600
output-artifact-directory: dist/tools

- id: unsigned-exe
if: env.SIGNING == 'true'
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
Expand Down Expand Up @@ -197,11 +252,18 @@ jobs:
if: env.SIGNING == 'true'
shell: pwsh
run: |
foreach ($file in @('dist/bullet.exe', "dist/installer/Bullet-Setup-$env:VERSION-x64.exe")) {
$files = @('dist/bullet.exe', "dist/installer/Bullet-Setup-$env:VERSION-x64.exe")
if ($env:HAS_ENGINE_TOKEN -eq 'true') { $files += @('dist/tools/bullet-br.exe', 'dist/tools/bullet-br.dll') }
foreach ($file in $files) {
$signature = Get-AuthenticodeSignature $file
"{0}: {1} {2}" -f $file, $signature.Status, $signature.SignerCertificate.Subject
if ($signature.Status -ne 'Valid') { throw "$file is not validly signed" }
}
foreach ($file in @('dist/tools/bullet-br.exe', 'dist/tools/bullet-br.dll')) {
if (-not (Test-Path $file)) { continue }
$publisher = (Get-AuthenticodeSignature $file).SignerCertificate.GetNameInfo('SimpleName', $false)
if ($publisher -ne $env:BULLET_NATIVE_PUBLISHER) { throw "$file is signed by '$publisher', but Bullet expects '$env:BULLET_NATIVE_PUBLISHER'" }
}

- name: Checksums
shell: pwsh
Expand Down
6 changes: 0 additions & 6 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,13 @@ strip_rust_comments.py
__pycache__/
*.pyc
.mypy_cache/
resultados_ltk/

# Motor de Injeção e DLL Proprietários (mantidos no repositório privado Isllanrx/bullet_dll)
crates/bullet-native-dll/
crates/bullet-native-host/
crates/bullet-native-protocol/
crates/bullet-native-test-harness/
crates/bullet-app/src/diagnostics/native_integration/
crates/bullet-inject/examples/native_owned_pipeline.rs
crates/bullet-inject/src/injector/overlay_process/native.rs
crates/bullet-inject/src/pipeline/spawn.rs
crates/bullet-inject/src/pipeline/validation.rs
crates/bullet-inject/src/provider/
crates/bullet-inject/tests/native_provider_orchestration.rs
crates/bullet-wad/tests/native_engine_validation.rs
scratch/
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 8 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,20 +67,14 @@ it, and when the game starts it reads that copy instead of its own. The game ins
The script checks the installer against the release's `SHA256SUMS` and its Authenticode signature before
installing.

2. **Add the injector.** Bullet uses two files from League Toolkit, `ltk_patcher_host.exe` and
`ltk_patcher_dll.dll`, which are not bundled. On first start Bullet offers to download them from the newest
[LTK Manager](https://github.com/LeagueToolkit/ltk-manager) release, refuses any file with a foreign or broken signature and copies them
into `C:\Program Files\Bullet\tools` (Windows asks for permission only for that copy). To copy them by hand
from an installed LTK Manager, in PowerShell **as administrator**:

```powershell
Copy-Item "$env:ProgramFiles\LTK Manager\ltk_patcher_host.exe", "$env:ProgramFiles\LTK Manager\ltk_patcher_dll.dll" "$env:ProgramFiles\Bullet\tools" -Force
```

Bullet accepts the files signed by League Toolkit's publisher (Natoken LLC) or published unsigned in an official
LTK Manager release, refuses a foreign or broken signature, and installs a newer injector by itself after a patch.
2. **The native engine comes with it.** The installer places Bullet's own injection engine, `bullet-br.exe` and
`bullet-br.dll`, in `C:\Program Files\Bullet\tools`. Nothing else is downloaded. Official releases carry Bullet's
Authenticode signature, and Bullet refuses to run an engine file signed by anyone else.

3. **Start Bullet** from the Start menu, normally (not as administrator). It lives in the system tray.
On the first start Bullet asks you to sign in with GitHub: it shows a code, opens github.com and you enter the
code there. Bullet then checks that your account starred this repository. The check repeats on every start; while
offline, a check from the last 7 days is accepted. The sign-in is stored for your Windows account only.

## Usage

Expand All @@ -96,7 +90,7 @@ your lobby. Optional settings are listed in [`.env.example`](.env.example).

Logs are in `%LOCALAPPDATA%\Bullet\logs` (the tray opens the folder); `BULLET_LOG=debug` adds detail. **Export
diagnostics** in the control panel zips everything needed for a report. If a skin or mod breaks match loading,
turn off **Inject skins** in the control panel. Close LTK Manager while Bullet runs: two injectors conflict.
turn off **Inject skins** in the control panel. Close other skin tools while Bullet runs: two injectors conflict.

Attach the log when you open an [issue](https://github.com/Isllanrx/Bullet/issues), or ask on
[Discord](https://discord.gg/e2dH2nUjd9). Security issues go through a
Expand Down Expand Up @@ -132,7 +126,7 @@ affiliated with or endorsed by Riot Games; League of Legends is a trademark of R
## License & Intellectual Property

- **Public Repository:** The source code in this repository is licensed under the [MIT License](LICENSE).
- **Proprietary Native Engine & DLL:** The native injector host `bullet-native-host.exe`, native DLL `bullet_native_dll.dll`,
- **Proprietary Native Engine & DLL:** The native injector host `bullet-br.exe`, native DLL `bullet-br.dll`,
and native IPC protocols are **closed-source proprietary software** owned exclusively by Isllan Toso and maintained in
a private repository (`Isllanrx/bullet_dll`). They are NOT covered by the MIT license.
- **No Commercial Use:** Commercialization, monetization, sale, or paid distribution of the native binaries is strictly prohibited.
Expand Down
27 changes: 4 additions & 23 deletions THIRD-PARTY-NOTICES.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ components Bullet uses or depends on and the terms they come with.

## Bullet Native Engine & DLL (Proprietary Subsystem)

The Bullet Native Injector Engine `bullet-native-host.exe`, Bullet Native DLL `bullet_native_dll.dll`,
The Bullet Native Injector Engine `bullet-br.exe`, Bullet Native DLL `bullet-br.dll`,
and associated native IPC protocols are **closed-source proprietary components** maintained in a private repository
(`Isllanrx/bullet_dll`) and owned exclusively by Isllan Toso.

Expand All @@ -16,25 +16,6 @@ and associated native IPC protocols are **closed-source proprietary components**
hooking, protocol extraction, or automated reconstruction of the native engine and DLL binaries by any human,
automated reverse-engineering suite, or AI model / agent pipeline is strictly prohibited.

## LTK patcher (injector)

`ltk_patcher_host.exe` and `ltk_patcher_dll.dll` are made by the League Toolkit organization and ship with
[LTK Manager](https://github.com/LeagueToolkit/ltk-manager). They are **not** part of this repository, are
**not** covered by Bullet's MIT license, and are **not** included in Bullet's installer. The README links an
official way to get them (LTK Manager) and a convenience download mirror, which is not an official League
Toolkit release.

They are governed by the
[LTK Patcher License](https://github.com/LeagueToolkit/ltk-manager/blob/main/LTK-PATCHER-LICENSE.md), published by
League Toolkit. In short, it allows using, studying and building software that uses the binaries. Anyone who
redistributes them outside an unmodified official LTK Manager release must remove League Toolkit's code
signature and may only sign them with their own certificate. The official way to get them is to copy both
files from an LTK Manager release. Bullet only runs copies that carry a valid Authenticode signature from League Toolkit's publisher, whatever
their source.

For questions about these binaries or their license, use the contact published by League Toolkit in that
license. Bullet is not affiliated with or endorsed by League Toolkit.

## Rust crates

`bullet.exe` statically links open-source Rust crates from [crates.io](https://crates.io). Every crate in the
Expand Down Expand Up @@ -73,10 +54,10 @@ included in each crate's source, which is available from crates.io at the versio
## Reference projects

Bullet was built by studying the projects listed in the README's acknowledgements. No source code from them
is included. Where a reference is GPL-licensed (for example LTK Manager), Bullet reimplements the behavior it
needs independently.
is included, and no third-party injector is used or shipped. Where a reference is GPL-licensed, Bullet
reimplements the behavior it needs independently.

## Trademarks

League of Legends and Riot Games are trademarks or registered trademarks of Riot Games, Inc. Bullet is not
affiliated with, endorsed or sponsored by Riot Games or League Toolkit.
affiliated with, endorsed or sponsored by Riot Games.
Binary file modified assets/urgot-ingame.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/urgot-select.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading