Repository navigation
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34065353 | Triggered | Bearer Token | d4d2691 | docs/src/development/api.md | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Contributor
|
I'd use a proper thesaurus as a codelist for the relation type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relation_typefield onLinkedResource(related,uses,clone_of), unique together with source and target. Theinternalcolumn is removed.clone_oflink from the clone to the original. Only therelatedlinks are copied to the clone.linked_resourcesAPI:relation_typeis returned for each item and can be used as a filter (?relation_type=clone_of).POSTandDELETEonly work onrelatedlinks, the other types return a 400.relatedlinks. For maps the map viewer is not listed, it's preserved on save and it can't be added.Changes in geonode-mapstore-client
The current client keeps working, because
internalis still returned (trueonly foruses). Until it's updated the clone links are shown under "Linked To" / "Linked By".DetailsLinkedResources.jsxshould group byrelation_typeinstead ofinternal, with the new "Clone of" (linked_to) and "Cloned by" (linked_by) labels.MapViewerConfiguration.jsxdeletes the map viewer only when it has a singlelinkedBy. A cloned viewer now has its clone in that list, so only therelatedlinks should be counted.Upgrade notes
relatedfor the existing links and removes the duplicated ones (same source, target and type).LinkedResource(internal=...)orget_linked_resources(is_internal=...)must switch torelation_type.clone_oflink.