Repository navigation
Conversation
1 of 5 tasks
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required change in geonode-mapstore-client
The client imports the base hookset from
geonode.client, which doesn't exist anymore after this PR. Without the following change GeoNode fails at startup withImproperlyConfigured: Error importing geonode_mapstore_client.hooksets.geonode_mapstore_client/hooksets.pymust be changed to:The change works with GeoNode both before and after this PR, so it must be merged in the client first. The tests of this PR will fail until it's available on the client's master.
The
exceptbranch can be removed once this PR is merged.Old migrations
The migrations of the old app are removed from the code, but they remain recorded in the
django_migrationstable of existing deployments. They can be removed from the GeoNode database with:migrateapplies the old migrations again and the records come back.geonode_clientlabel has its own migrations.geonode_clientapp adds its own models, which is not expected. In that case its initial migration would be considered already applied.Upgrade notes
Projects that import from
geonode.client, or that subclassgeonode.client.hooksets.BaseHookSet, must switch togeonode.legacy_client. Theclient_lib_tagstemplate library keeps its name.The following settings (and the corresponding environment variables) are renamed:
GEONODE_CLIENT_HOOKSETbecomesGEONODE_LEGACY_CLIENT_HOOKSETGEONODE_CLIENT_LAYER_PREVIEW_LIBRARYbecomesGEONODE_LEGACY_CLIENT_LAYER_PREVIEW_LIBRARYThe old names are ignored without any warning. Nothing changes for deployments using the defaults. Deployments with a custom hookset, or a preview library different from
mapstore, fall back to MapStore until their.envor settings are updated.geonode_clienthas been removed from theappsanddumpslists of the sample Backup & Restore settings files. Deployments using their own copy must remove it too, otherwise the backup fails withNo installed app with label 'geonode_client'. Existing backups can still be restored.The settings reference in the documentation repo (
basic/settings/index.rst) must be updated with the new setting name.