Repository navigation
Remove unsafe type assertion in splitCollectionMemberKey - #843
Conversation
Split the typed overload from a string implementation so the collection key can be returned without asserting CollectionKeyType.
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The checklist and "require tests" CI checks don't make sense here because there are no runtime changes. This is a type-only change. |
Details
Removes the unsafe
collectionKey as CollectionKeyTypeinsplitCollectionMemberKeyby splitting a typed overload from astringimplementation.This is a small, main-based fix so the corresponding
eslint.seatbelt.tsvrow in #802 can be dropped after merge.Related Issues
For #802
Linked E/App PR
Automated Tests
No new tests. Type-only overload split; existing
tests/unit/OnyxKeysTest.tscovers runtime behavior.npx tsc --noEmitpasses.Manual Tests
lib/OnyxKeys.tsand confirmsplitCollectionMemberKeyhas noasassertion.npx tsc --noEmitand confirm it passes.Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari