Skip to content

[No QA] Order CODEOWNERS so the workflows rule takes precedence - #971

Merged
marcochavezf merged 1 commit into
mainfrom
nicolas-codeowners-order
Nov 10, 2026
Merged

marcochavezf merged 1 commit into
mainfrom
nicolas-codeowners-order

Conversation

@NicolasBonet

Copy link
Copy Markdown
Contributor

In CODEOWNERS the last matching pattern wins. Because * @Expensify/pullerbear came after the .github/workflows/ rule, it also matched workflow files and the dedicated workflow owners were never requested.

This puts the * rule first so the .github/workflows/ rule applies to workflow changes, which is the same ordering App uses. The same change is going into react-native-onyx: Expensify/react-native-onyx#891

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/702575

Tests

  1. No code changes, so no unit tests apply.
  2. After merge, open a PR that touches a file in .github/workflows/ and confirm @AndrewGable, @coleaeason and @rafecolton are requested as code owners. A PR touching any other file should still request @Expensify/pullerbear.

QA

  1. None, this only changes who GitHub requests reviews from.
  2. No regression areas.

@NicolasBonet
NicolasBonet requested a review from a team as a code owner November 10, 2026 21:03
@melvin-bot
melvin-bot Bot requested review from marcochavezf and removed request for a team November 10, 2026 21:04
@NicolasBonet NicolasBonet changed the title Order CODEOWNERS so the workflows rule takes precedence [No QA] Order CODEOWNERS so the workflows rule takes precedence Nov 10, 2026
@marcochavezf
marcochavezf merged commit 2249999 into main Nov 10, 2026
8 of 9 checks passed
@marcochavezf
marcochavezf deleted the nicolas-codeowners-order branch November 10, 2026 23:51
@os-botify

os-botify Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

🚀 Published to npm in 2.0.226 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants