Repository navigation
[No QA] Order CODEOWNERS so the workflows rule takes precedence - #971
Merged
Merged
Conversation
Merged
42 tasks done
melvin-bot
Bot
requested review from
marcochavezf
and removed request for
a team
November 10, 2026 21:04
marcochavezf
approved these changes
Nov 10, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CODEOWNERS the last matching pattern wins. Because
* @Expensify/pullerbearcame after the.github/workflows/rule, it also matched workflow files and the dedicated workflow owners were never requested.This puts the
*rule first so the.github/workflows/rule applies to workflow changes, which is the same ordering App uses. The same change is going into react-native-onyx: Expensify/react-native-onyx#891Fixed Issues
$ https://github.com/Expensify/Expensify/issues/702575
Tests
.github/workflows/and confirm @AndrewGable, @coleaeason and @rafecolton are requested as code owners. A PR touching any other file should still request @Expensify/pullerbear.QA