Repository navigation
Bump @babel/plugin-transform-modules-systemjs to 7.29.8 - #963
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
arosiclair
and removed request for
a team
October 26, 2026 12:26
arosiclair
reviewed
Oct 26, 2026
arosiclair
left a comment
Contributor
There was a problem hiding this comment.
I think this would affect the build for Web-E so it might be worth it to test npm run grunt there before merging this
Contributor
|
@arosiclair, added tests. this is ready for review! |
arosiclair
approved these changes
Nov 16, 2026
Contributor
|
@MonilBhavsar you have to approve too |
MonilBhavsar
approved these changes
Nov 16, 2026
Contributor
|
done |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps transitive dev dep
@babel/plugin-transform-modules-systemjs7.25.9 → 7.29.8 to fix GHSA-fv7c-fp4j-7gwp (patched in 7.29.4). Lockfile-only (npm update); also pulls@babel/{parser,generator,traverse,types}patch bumps.Usage: Pulled in by
@babel/preset-env, used only by Jest viababel.config.js. SystemJS transform is never enabled, and nothing ships indist/.Change Log
__proto__as an export name (babel#18044)Fixed Issues
$ https://github.com/Expensify/Expensify/issues/695519
Tests
Ran following on expensify-common repo
In Web-Expensify ran following
MelvinBot ran on Node 24:
npm test(748/748 pass),npm run typecheck,npm run lint,npm run build— all pass.QA
No QA needed (dev-only). Manual checks:
npm ci && npm test→ all pass.npm ls @babel/plugin-transform-modules-systemjs→7.29.8.npm run build→ succeeds,dist/unchanged.