Repository navigation
fix: report metrics without optional firing-count metadata - #193
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the still-useful missing-counts safeguard from the experimental
tweak-analysisbranch onto the current result-analysis implementation. Other pieces of that branch (per-latent F1 and scorer filtering) are already in main, so merging its historical version wholesale would regress newer work.When firing-count metadata is unavailable, skip firing-rate plots and count-derived statistics, but still report classification metrics. Avoid formatting an unavailable weighted F1 as a float. Return early for empty score data before grouping or plotting.
Validation: six result-analysis tests pass, including missing-count and empty-data logging regressions. Ruff and whitespace checks pass. No model inference or plot rendering is needed for these tests.