Repository navigation
Add fromInput functions to the net data types - #8970
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 856d96e The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
- Accept address bytes, segments, and structured parts across net types - Update resolver inputs, tests, and API documentation
fubhy
force-pushed
the
feat/net-from-input
branch
from
October 9, 2026 16:03
ffe98f6 to
7c8ebdc
Compare
- Parse host entries through `NetAddress.ipFromInput` - Update examples and tests to use string and tuple inputs
- Accept address inputs and IPv6 scope IDs in socket constructors - Reject sparse address arrays and use shared inspection support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*Inputtypes (the value or a string to parse) andfromInputfunctions for theeffect/netdata types:NetAddress:ipFromInput,ipv4FromInput,ipv6FromInput,macAddressFromInput,scopedIpv6LiteralFromInput,inetAddressFromInputHost:domainNameFromInput,hostFromInput,hostPortFromInputIpNetworkandIpInterface:fromInput,ipv4FromInput,ipv6FromInput(IpInterfaceaccepts the same parse options asfromString)fromInputchecks the type guard first and returns values unchanged, then parses anything else with the matchingfromStringparser, likeNetAddress.socketAddressFromInputandDateTime.makeUnsafe. Domain names and scoped IPv6 literals are strings, so they are always parsed.Unsafevariant,fromInputhas one too:Result.getOrThrowof the safe function, like the existing*FromStringUnsafefunctions.unstableinNetAddress,IpNetwork, andIpInterface,experimentalinHost, andexperimentalfor the scoped IPv6 literal input, which matchesScopedIpv6Literal.Extracted from #8962, which builds on it.
Validation
pnpm lint-fix,pnpm check,pnpm jsdocs --checkpnpm doctest --run packages/effect/src/net/NetAddress.tspnpm test --runon theNetAddress,Host,IpNetwork, andIpInterfacetests