Repository navigation
refactor(scripts): replace dayofyear with day_of_year (pandas) - #52
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
xiangtaoxu
approved these changes
Nov 3, 2026
xiangtaoxu
left a comment
Contributor
There was a problem hiding this comment.
I will merge this after PR 49
3 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
During the tests of #51, some of the tests created hundreds to thousands of warnings. The warnings were due to pandas 4 deprecating
dayofyearonDatetimeIndexandTimestamp. For now this is just a bunch of warning messages, but they may become errors in the future. This pull request renames the 7 uses inscripts/calibrate_fast/tower.py,scripts/calibrate_fast/data_rules.pyandexamples/example02_canopy_phenology/run_phenology.py.Effect on results (tick exactly one; CI checks)
Verification.
User-facing changes (tick all that apply; each needs an "Upgrading" note in the changelog)
Verification
compared. Ran
examples/example02_canopy_phenology/run_phenology.pyonbetaand on this branch(pandas 4): the printed parameters and scores and the figure are identical, and the 272
dayofyearwarnings onbetaare gone.scripts/prepare_input/flux_tower/tests,scripts/calibrate_fast): 100 passed,5 skipped (those need
EDMORE_LIBandEDMORE_MAIN), pandas 4, and the deprecation warningsare gone (before, about 2,070 of them).
long; expected for a science change): not applicableCredit and AI use
ran the tests and the example, and wrote the changelog entry. I updated the changelog entry with the PR number.
Not in this PR