Repository navigation
Conversation
- neuboundaries_light: connect each Neumann node to its quadtree neighbour opposite the open side, instead of the nearest inner node. At a refinement transition the nearest inner node was the fine node diagonally inward; when downwave it used the Neumann node as upwind point and so fed on its own energy, giving a shadow wedge in Hm0 and Hm0_ig. Corner nodes keep the nearest-node connection. - Solver: update Neumann nodes directly after their inner node within each sweep (inverse map neu_start/neu_list), so energy travels along a Neumann edge in one sweep instead of one node per sweep. Flat-bed tests (refinement touching the Neumann edge): 1st percentile Hm0/Hs 0.915 -> 0.998 at 270 deg, 0.557 -> 0.916 at 300 deg. Unchanged for closed edges. Rotated test model now uniform Hm0 within 0.3 %. Co-Authored-By: SFINCS <sfincs@deltares.nl>
For wave directions entering through a Neumann edge, the upwind point of the node next to the edge lies mostly on the Neumann node connected to that same node, which holds a copy of the node's own energy. Treated explicitly, this made the update a slow fixed-point iteration of the node on itself (about 150 iterations at 300 deg in the flat-bed tests). These contributions are now moved to the diagonal of the directional system, for ee and ee_ig, which gives the zero-gradient result at once. Only nodes with connected Neumann nodes are affected. Flat-bed tests: strict runs converge in 6 instead of about 150 iterations; 1st percentile Hm0/Hs at 300 deg 0.916 -> 1.000. Unchanged for closed edges. Co-Authored-By: SFINCS <sfincs@deltares.nl>
Leynse
marked this pull request as draft
November 19, 2026 16:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please briefly describe the purpose of this pull request and the main changes introduced.
Checklist
Before marking this PR as Ready for Review, please confirm:
Compilation
Testing (for additions to the code)
If this PR modifies model functionality:
If this PR adds model functionality:
Documentation
HydroMT-SFINCS
Self Review
Additional Notes