Skip to content

Add draft CLAs and contributor workflow - #443

Open
maartenvanormondt wants to merge 2 commits into
mainfrom
feature/contributor-agreement
Open

maartenvanormondt wants to merge 2 commits into
mainfrom
feature/contributor-agreement

Conversation

@maartenvanormondt

Copy link
Copy Markdown
Contributor

Add draft individual and entity CLAs, a CLA-checking workflow, and contribution guidance. Update the pull request checklist and documentation.

Description

Please briefly describe the purpose of this pull request and the main changes introduced.

Checklist

Before marking this PR as Ready for Review, please confirm:

Compilation

  • Compiles and runs successfully on Windows
  • Compiles and runs successfully on Linux (CPU)
  • Compiles and runs successfully on Linux (GPU)

Testing (for additions to the code)

If this PR modifies model functionality:
 

  • Testbed has been run, and significant performance change has been adressed

If this PR adds model functionality:
 

  • A conceptual test has been added to the testbed.
  • A real-world test case has been added to the testbed.

Documentation

  • Relevant documentation has been updated to reflect the changes.
  • Examples, tutorials, or user guides have been updated where necessary.

HydroMT-SFINCS

Self Review

  • I have reviewed my own changes.
  • Fortran changes follow the coding style.

Additional Notes

Add draft individual and entity CLAs, a CLA-checking workflow, and contribution guidance. Update the pull request checklist and documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Approval is blocked by unresolved critical security and legal issues in the privileged CLA workflow, including a mutable action reference and enforcement of an unfinalized agreement.

3 open issues
What changed in this PR

Adds draft individual and entity contributor license agreements, automated CLA checking, and contribution guidance for SFINCS.

Changes:

  • Adds draft individual and entity CLA documents.
  • Adds a GitHub Actions workflow for checking contributor CLA status.
  • Updates contribution documentation, README and example guidance, and the pull request checklist.
File Description
README.rst Links contributors to the contribution guide and explains the CLA requirement.
docs/​example.rst Adds CLA information to the contribution documentation.
CONTRIBUTING.md Introduces contribution, CLA, third-party code, and pull request guidance.
.github/​workflows/​cla.yml Configures automated CLA checking and signature storage.
.github/​pull_request_template.md Adds CLA and third-party code checklist items.
.github/​cla/​individual_cla.md Adds the draft individual contributor agreement.
.github/​cla/​entity_cla.md Adds the draft entity contributor agreement.

Review effort: Lite

Comment thread .github/workflows/cla.yml Resolved
Comment thread .github/workflows/cla.yml Resolved
Comment thread .github/workflows/cla.yml Resolved
@maartenvanormondt
maartenvanormondt marked this pull request as draft November 13, 2026 14:29
Pin the write-enabled CLA action to its v2.6.1 commit SHA and clarify how staff, entity-CLA designees, and automation accounts are exempted.
@Leynse
Leynse marked this pull request as ready for review November 18, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants