Repository navigation
Show syntax errors in the scripting terminal editor - #87
Open
rubensworks wants to merge 1 commit into
Open
rubensworks wants to merge 1 commit into
rubensworks wants to merge 1 commit into
Conversation
This was referenced Oct 18, 2026
Coverage Report for CI Build 39152695741Coverage at 44.072% (no base build to compare)Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Syntax errors only showed up when a variable card using the script was evaluated somewhere, for example as an error in a display panel. Check the active script for syntax errors on the server, without executing it, once it hasn't changed for half a second. Mark the line of the first error with a red line number and gutter background, mark its position on the scrollbar, and show its message when hovering it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
rubensworks
force-pushed
the
terminal-ux-clean/3-editing-features
branch
from
October 18, 2026 18:07
fa706d0 to
bf7170f
Compare
rubensworks
force-pushed
the
terminal-ux-clean/4-feedback
branch
from
October 18, 2026 18:07
037897a to
7c6fa71
Compare
Base automatically changed from
terminal-ux-clean/3-editing-features
to
master-1.21-lts
October 18, 2026 18:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #80, with the same changes as one standalone commit. Phase 4 of the scripting terminal UX improvements, stacked on #86 (then #85).
Problem
A syntax error in a script only became visible once a variable card using it was evaluated, e.g. as an X in a display panel that you then had to hover (see #5). The terminal itself gave no feedback, and the info book said so too.
Changes
ILanguageHandlergets a defaultcheckSyntax(Path, String)that returnsnull, so other language handlers keep working.Context.parse, which parses the script without executing it.TerminalScriptingSyntaxErrorPacket.Validation
In a dev client (clientdevbridge), with a missing
)on line 7 of a 40-line script:;is underlined, and hovering showsSyntaxError: script0.js:7:23 Expected , but found ;. Typing the missing)clears all markers.New unit tests check the result for valid code, a syntax error (line and column), an unclosed block, and that
throw new Error(...)isn't executed.Dropped from the original plan
Testing
./gradlew buildpasses, including the new unit tests../gradlew runGameTestServer: all 23 tests pass.Generated by Claude Code