Repository navigation
Add integration tests.yml for hello and host-details functions - #137
Merged
Merged
Conversation
Two test cases for the hello handler covering the happy path (valid name, expects 200 + greeting) and the error case (missing name, expects 400 + error message). These are integration tests for the new foundry functions test command (CLI 2.1.0+), which runs them against the deployed function.
Three test cases: valid host ID (placeholder, replace with a real AID), missing host_id (400), and invalid host ID (404). Shows how to test a function that calls the FalconPy Hosts API.
The Hosts API rejects a malformed device ID with a 400, not a 404.
mraible
changed the title
mraible
marked this pull request as ready for review
October 7, 2026 00:03
Adds a Testing section covering pytest from a repo-root virtual environment and foundry functions test, including the host ID and one-time install that the host-details tests need.
prvn
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
tests.ymlfiles for thehelloandhost-detailsfunctions, so thefoundry functions testcommand (CLI 2.1.0+) has integration tests to run against the deployed functions.functions/hello/tests.ymlis self-contained.valid_namesends{"name": "Foundry"}and expects a 200 with the greeting, andmissing_namesends{}and expects a 400 with"missing name from request body". Anyone who clones and deploys can runfoundry functions test --function helloright away.functions/host-details/tests.ymlexercises a handler that calls the Hosts API through FalconPy.missing_host_idexpects a 400 from the handler's own check, andinvalid_host_idexpects a 400 because the Hosts API rejects a malformed device ID as a bad request.valid_host_iduses aYOUR_HOST_AID_HEREplaceholder that you replace with a host ID from your tenant. Because FalconPy's context-aware authentication needs an installed app, the two cases that reach the API return a 403 (app is not installed) until the app is released and installed once. After that, later deploys run without another release. All three cases pass against an installed app.Looking for feedback on whether integration test files like these belong in the sample repos alongside the existing unit tests (
test_main.py), and whether the placeholder host ID is acceptable or the valid case should be left out.The README now has a Testing section that explains how to run both the existing unit tests (pytest from a repo-root virtual environment) and these integration tests.