Skip to content

Prevent redefinition of mtr_enabled - #1291

Merged
facontidavide merged 1 commit into
BehaviorTree:masterfrom
SunBlack:mtr_enabled
Nov 13, 2026
Merged

facontidavide merged 1 commit into
BehaviorTree:masterfrom
SunBlack:mtr_enabled

Conversation

@SunBlack

@SunBlack SunBlack commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Backport from microsoft/vcpkg#55044

No idea what has changed between 4.11.0 and 4.11.1 which can causes this, but we get in vcpkg (the flag seems to be added by the minitrace external dependency):

[39/44] /usr/bin/c++ -DBTCPP_LIBRARY_VERSION=\"4.11.1\" -DMTR_BUILDING_WITH_CMAKE -DMTR_ENABLED -DTINYXML2_DEBUG -D_FILE_OFFSET_BITS=64 -I/Users/builduser/Data/b/behaviortree-cpp/src/4.11.1-8b14d9b426.clean/include -I/Users/builduser/Data/b/behaviortree-cpp/arm64-osx-dbg/generated -I/Users/builduser/Data/b/behaviortree-cpp/src/4.11.1-8b14d9b426.clean/3rdparty/minicoro -isystem /Users/builduser/Data/installed/arm64-osx/include -fPIC -g -std=gnu++17 -arch arm64 -fPIC   -Wpedantic -fno-omit-frame-pointer -Wall -Wextra -Wpedantic -Wnull-dereference -Werror -MD -MT CMakeFiles/behaviortree_cpp.dir/src/loggers/bt_minitrace_logger.cpp.o -MF CMakeFiles/behaviortree_cpp.dir/src/loggers/bt_minitrace_logger.cpp.o.d -o CMakeFiles/behaviortree_cpp.dir/src/loggers/bt_minitrace_logger.cpp.o -c /Users/builduser/Data/b/behaviortree-cpp/src/4.11.1-8b14d9b426.clean/src/loggers/bt_minitrace_logger.cpp
FAILED: [code=1] CMakeFiles/behaviortree_cpp.dir/src/loggers/bt_minitrace_logger.cpp.o 
/usr/bin/c++ -DBTCPP_LIBRARY_VERSION=\"4.11.1\" -DMTR_BUILDING_WITH_CMAKE -DMTR_ENABLED -DTINYXML2_DEBUG -D_FILE_OFFSET_BITS=64 -I/Users/builduser/Data/b/behaviortree-cpp/src/4.11.1-8b14d9b426.clean/include -I/Users/builduser/Data/b/behaviortree-cpp/arm64-osx-dbg/generated -I/Users/builduser/Data/b/behaviortree-cpp/src/4.11.1-8b14d9b426.clean/3rdparty/minicoro -isystem /Users/builduser/Data/installed/arm64-osx/include -fPIC -g -std=gnu++17 -arch arm64 -fPIC   -Wpedantic -fno-omit-frame-pointer -Wall -Wextra -Wpedantic -Wnull-dereference -Werror -MD -MT CMakeFiles/behaviortree_cpp.dir/src/loggers/bt_minitrace_logger.cpp.o -MF CMakeFiles/behaviortree_cpp.dir/src/loggers/bt_minitrace_logger.cpp.o.d -o CMakeFiles/behaviortree_cpp.dir/src/loggers/bt_minitrace_logger.cpp.o -c /Users/builduser/Data/b/behaviortree-cpp/src/4.11.1-8b14d9b426.clean/src/loggers/bt_minitrace_logger.cpp
/Users/builduser/Data/b/behaviortree-cpp/src/4.11.1-8b14d9b426.clean/src/loggers/bt_minitrace_logger.cpp:4:9: error: 'MTR_ENABLED' macro redefined [-Werror,-Wmacro-redefined]
    4 | #define MTR_ENABLED true
      |         ^
<command line>:3:9: note: previous definition is here
    3 | #define MTR_ENABLED 1
      |         ^
1 error generated.

@facontidavide

Copy link
Copy Markdown
Collaborator

CI is unhappy

@facontidavide
facontidavide merged commit 365b2e4 into BehaviorTree:master Nov 13, 2026
17 checks passed
@SunBlack
SunBlack deleted the mtr_enabled branch November 13, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants