Skip to content

Removed the settings gear from tree view as it only contained setting… #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alail-ims merged 1 commit into from
Oct 13, 2026
Merged

Removed the settings gear from tree view as it only contained setting… #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions apps/editor/src/ui/editor/EditorCanvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1736,7 +1736,9 @@ export default function EditorCanvas({ onBack, onSaveToServer, onArchiveFramewor
tenantId={tenantId ?? undefined}
onChangePassword={authStatus === 'authenticated' && changePassword ? () => void changePassword() : undefined}
reserveRightForPanel={sidePanelOpen}
showSettings
// Settings menu is canvas-only (edge style, view switching), so it's
// hidden while Tree View is the only view (see featureFlags.ts).
showSettings={CANVAS_VIEW_ENABLED}
isDirty={isDirty}
saveStatus={saveStatus}
saveError={saveError}
Expand All @@ -1757,7 +1759,7 @@ export default function EditorCanvas({ onBack, onSaveToServer, onArchiveFramewor
}
: undefined
}
onOpenSettings={() => setSettingsOpen(true)}
onOpenSettings={CANVAS_VIEW_ENABLED ? () => setSettingsOpen(true) : undefined}
onResetHierarchy={CANVAS_VIEW_ENABLED ? () => { setActiveView('canvas'); applyHierarchyLayout() } : undefined}
onResetStar={CANVAS_VIEW_ENABLED ? () => { setActiveView('canvas'); applyStarLayout() } : undefined}
onSwitchTreeView={CANVAS_VIEW_ENABLED ? () => setActiveView(activeView === 'tree' ? 'canvas' : 'tree') : undefined}
Expand Down Expand Up @@ -1939,12 +1941,13 @@ export default function EditorCanvas({ onBack, onSaveToServer, onArchiveFramewor
}}
/>

<SettingsModal
{/* Edge style is the only setting, and it only affects the canvas. */}
{CANVAS_VIEW_ENABLED ? <SettingsModal
open={settingsOpen}
settings={settings}
onClose={() => setSettingsOpen(false)}
onSave={updateSettings}
/>
/> : null}

{showBrowsePanel ? (
<div className="fixed right-0 top-0 z-20 h-screen w-[min(460px,92vw)] border-l border-black/10 bg-white shadow-xl">
Expand Down
Loading