Duplicate Quotes in english.json

[spaceKite769]

I noticed these quote entries may be duplicates in frontend/static/quotes/english.json :

Exact text matches

• IDs 5026 and 7629: “If you want to know what a man's like, take a good look at how he treats his inferiors, not his equals.”
  • Source listed: Harry Potter and the Goblet of Fire
• IDs 230 and 7708: “And the game was over and the player woke up from the dream...”
  • Sources listed: End Poem and Minecraft

Punctuation-only difference

• IDs 6854 and 6997: “Life is a book and there are...” / “Life is a book, and there are...”
  • Sources listed: Clockwork Princess / Clockwork Princess by Cassandra Clare

what to do in this situation?

[alok-108]

@spaceKite769 I checked the current english.json on master and your findings are right:

• 5026 and 7629 have the same text and the same source (Harry Potter and the Goblet of Fire).
• 230 and 7708 have the same text (227 characters) but different sources, "End Poem" and "Minecraft".
• 6854 and 6997 differ only by a comma (66 vs 67 characters), and the source of 6997 is "Clockwork Princess by Cassandra Clare" while 6854 is just "Clockwork Princess".

The quote guidelines in docs/CONTRIBUTING.md say quotes shouldn't be duplicates of existing ones, so it's worth fixing. Since this is just a data change, the easiest way is a pull request, no dev setup needed. Fork the repo, open frontend/static/quotes/english.json in the web editor (press . on your fork), delete the duplicate entries, and open a PR. The docs ask for the title format impr(quotes): <what you did> (@yourusername), so something like impr(quotes): remove duplicate English quotes (@yourusername).

I'd put the ID pairs from your list in the PR description. For the pairs with different sources (230/7708) and the comma-only one, it's the maintainers' call which entry to keep, so say which one you removed and why. I couldn't find anything in the docs about what to do with the ids that are left over, so I'd mention that you left the other ids unchanged and let them tell you if they want it handled differently.