Repository navigation
docs: Rule-based value groups in workbook calculated fields - #12442
igorlukanin wants to merge 1 commit into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
Claude finished @igorlukanin's task in 57s —— View job Looks good, two wording fixes worth making: 0 high, 0 medium, 2 low Review details
Findings (inline)
Not verifiedThe workbook UI isn't in this repo, so I couldn't check these against the code:
I went by the PR's test plan for them. Notes
Review threadsThe listing returned 0 of my own threads, so none were resolved or re-affirmed. |
| ELSE '3. >= 18' END | ||
| ``` | ||
|
|
||
| Value groups render each group as a branch, values as `IN` and rules as `ILIKE`: |
There was a problem hiding this comment.
Low: This says every rule renders as ILIKE, but Is empty renders as = ''. Your test plan lists that operator separately, and line 127 says it matches ''. A reader looking for their Is empty group in the preview won't find an ILIKE.
| Value groups render each group as a branch, values as `IN` and rules as `ILIKE`: | |
| Value groups render each group as a branch: picked values as `IN`, text rules as `ILIKE`, and **Is empty** as `= ''`: |
| - **Contains**, **Starts with**, and **Ends with** define the group by a rule on | ||
| the text you type. **Is empty** matches empty strings (`''`), not `NULL`. |
There was a problem hiding this comment.
Low: This bullet describes the operators as a "rule on the text you type", and Is empty is tacked onto it. Is empty takes no text, so it reads like a fourth text operator that somehow ignores the search box. Splitting the two keeps the bullet accurate:
| - **Contains**, **Starts with**, and **Ends with** define the group by a rule on | |
| the text you type. **Is empty** matches empty strings (`''`), not `NULL`. | |
| - **Contains**, **Starts with**, and **Ends with** define the group by a rule on | |
| the text you type; **Is empty** defines it by a rule matching empty strings | |
| (`''`), not `NULL`. |
Summary
Updates Bins and value groups for groups that match values by a rule:
'', notNULL.INandILIKE.Test plan
IN,ILIKE,= '',ELSE 'Other') against the shipped implementation and its tests.mint dev: the page renders (200);mint broken-linksreports nothing for the page.🤖 Generated with Claude Code