Skip to content

docs: Rule-based value groups in workbook calculated fields - #12442

Open
igorlukanin wants to merge 1 commit into
masterfrom
docs/value-group-rules
Open

igorlukanin wants to merge 1 commit into
masterfrom
docs/value-group-rules

Conversation

@igorlukanin

Copy link
Copy Markdown
Member

Summary

Updates Bins and value groups for groups that match values by a rule:

  • The operator in front of the search box: Search, Contains, Starts with, Ends with, Is empty, and the Add as rule button.
  • Rules match case-insensitively and are evaluated at query time; Is empty matches '', not NULL.
  • Select all N matches and its 100-value cap.
  • Group order is precedence: a value joins the first group that matches it. This replaces "a value belongs to one group at a time".
  • A Semantic SQL example for a value group with IN and ILIKE.

Test plan

  • Checked UI labels, the 100-value cap, and the generated SQL (IN, ILIKE, = '', ELSE 'Other') against the shipped implementation and its tests.
  • mint dev: the page renders (200); mint broken-links reports nothing for the page.

🤖 Generated with Claude Code

@igorlukanin
igorlukanin requested a review from keydunov as a code owner October 27, 2026 14:10
@mintlify

mintlify Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
cubed3 🟢 Ready View Preview Oct 27, 2026, 2:11 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@github-actions github-actions Bot added the docs Issues that require a documentation improvement label Oct 27, 2026
@claude

claude Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 57s —— View job


Looks good, two wording fixes worth making: 0 high, 0 medium, 2 low

Review details
  • Read diff
  • Read the full page and check it against the implementation
  • Review threads
  • Post review

Findings (inline)

  • Low: calculated-fields.mdx:164 says every rule renders as ILIKE, but Is empty renders as = ''.
  • Low: calculated-fields.mdx:126-127 describes Is empty as a "rule on the text you type", but it takes no text.

Not verified

The workbook UI isn't in this repo, so I couldn't check these against the code:

  • the operator labels
  • the Select all N matches text and its 100-value cap
  • the generated SQL

I went by the PR's test plan for them.

Notes

  • The page now reads well and is consistent with itself:
    • First-match precedence, the fact that moving a value doesn't touch rules, and NULL falling into Everything else fit together.
    • The CASE example matches the precedence description.
  • Pre-existing, not from this PR: the paragraph on position prefixes (calculated-fields.mdx:143) says "Bucket labels" right after the value-groups text. A reader could take it to cover value groups too, while the new SQL example shows 'Open' with no prefix. Saying "Bin labels" there would remove the ambiguity.
  • Docs-only PR, so there is no user-facing-docs gap and no tests are needed.

Review threads

The listing returned 0 of my own threads, so none were resolved or re-affirmed.

ELSE '3. >= 18' END
```

Value groups render each group as a branch, values as `IN` and rules as `ILIKE`:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low: This says every rule renders as ILIKE, but Is empty renders as = ''. Your test plan lists that operator separately, and line 127 says it matches ''. A reader looking for their Is empty group in the preview won't find an ILIKE.

Suggested change
Value groups render each group as a branch, values as `IN` and rules as `ILIKE`:
Value groups render each group as a branch: picked values as `IN`, text rules as `ILIKE`, and **Is empty** as `= ''`:

Comment on lines +126 to +127
- **Contains**, **Starts with**, and **Ends with** define the group by a rule on
the text you type. **Is empty** matches empty strings (`''`), not `NULL`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low: This bullet describes the operators as a "rule on the text you type", and Is empty is tacked onto it. Is empty takes no text, so it reads like a fourth text operator that somehow ignores the search box. Splitting the two keeps the bullet accurate:

Suggested change
- **Contains**, **Starts with**, and **Ends with** define the group by a rule on
the text you type. **Is empty** matches empty strings (`''`), not `NULL`.
- **Contains**, **Starts with**, and **Ends with** define the group by a rule on
the text you type; **Is empty** defines it by a rule matching empty strings
(`''`), not `NULL`.

This branch was successfully deployed

1 active deployment
staging - docs-mintlify — 77fe7a6f Deployed Oct 27, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues that require a documentation improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant